这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@kloots
Copy link
Contributor

@kloots kloots commented Oct 23, 2017

This PR fixes issues #15 and #54. The core idea is to changeup how we style focus, moving from adding the focus-ring class in response to focus events preceded by keydown events, to simply leveraging keydown instead.

As noted in the code comments: keyup provides two advantages over our current approach:

  • It will reliably fire when the user is navigating from the browser chrome into the document (fixing issue When to match :focus-ring:? #33).
  • Requires one less event listener, while still ensuring we add focus-ring only in response to focus originating from the keyboard.

@alice
Copy link
Member

alice commented Oct 23, 2017

This is a great fix, but looks like the pull is against an older version of master - looks like you need to sync your workspace?

@kloots kloots force-pushed the style-keyboard-focus-on-keyup branch from 2cb5a22 to 3008874 Compare October 24, 2017 00:24
@kloots
Copy link
Contributor Author

kloots commented Oct 24, 2017

@alice so sorry about that! Should be all tidied up now!

@alice
Copy link
Member

alice commented Oct 24, 2017

👍

@alice alice merged commit 095094a into WICG:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants