Style keyboard focus on keyup #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #15 and #54. The core idea is to changeup how we style focus, moving from adding the
focus-ringclass in response tofocusevents preceded bykeydownevents, to simply leveragingkeydowninstead.As noted in the code comments:
keyupprovides two advantages over our current approach:focus-ringonly in response tofocusoriginating from the keyboard.