Add body class when loaded - fix #8 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Marked as non substantive for IPR from ash-nazg. |
stefanjudis
commented
Aug 10, 2017
| * to which it was previously applied. | ||
| * When switching windows, keep track of the focused element if it has a | ||
| * focus-ring class. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
These JSDOC changes are not intended by me. It seems like the docs in the dist file were not up to date. Now they're matching with the docs in src.
Collaborator
|
LGTM thank you @stefanjudis! |
Contributor
Author
|
Thanks so much for merging. Do you plan to also release a new version? 😊 |
Collaborator
|
Yep I just want to check in with @alice first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just about to implement the polyfill and came across #8. It addresses my concerns completely because the CSS I have in my project is as follows. 👇
This can destroy the complete focus handling in case of JS failure or loading troubles.
This PR adds the discussed behavior of the polyfill to add a
focus-ring-enabledclass to the body element when it's done doing its magic. ;)