Add "on navigate callback" #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@domfarolino This is done modulo the type definition for "on navigate callback", which is a TODO for this PR (not for the future). |
Collaborator
|
Got it, thanks. I think the type can just be something like "these steps, which take a foo and a bar" (with the steps defined below). Or if we ever need to set this asynchronously we can just make this super vague like https://html.spec.whatwg.org/multipage/urls-and-fetching.html#lazy-load-resumption-steps. |
Collaborator
Author
|
@domfarolino changed it to just say that the callback is "a series of steps". |
domfarolino
approved these changes
May 22, 2023
github-actions bot
added a commit
that referenced
this pull request
May 22, 2023
SHA: d0b5724 Reason: push, by gtanzer Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff