Remove FencedFrameConfig#url #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzer
approved these changes
May 18, 2023
github-actions bot
added a commit
that referenced
this pull request
May 18, 2023
SHA: 204e674 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 19, 2023
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 19, 2023
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2023
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147330}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 22, 2023
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147330}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2023
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147330}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 10, 2023
…a=testonly
Automatic update from web-platform-tests
Remove FencedFrameConfig URL attribute
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147330}
--
wpt-commits: 4eab05e5e460d28219d324c13e5adcc94c5db109
wpt-pr: 40093
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 16, 2023
…a=testonly
Automatic update from web-platform-tests
Remove FencedFrameConfig URL attribute
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzerchromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <naskochromium.org>
Commit-Queue: Dominic Farolino <domchromium.org>
Cr-Commit-Position: refs/heads/main{#1147330}
--
wpt-commits: 4eab05e5e460d28219d324c13e5adcc94c5db109
wpt-pr: 40093
UltraBlame original commit: 3c5ecd4c7a60d1d2bb31f9ec7ceaf79a7c183a11
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 16, 2023
…a=testonly
Automatic update from web-platform-tests
Remove FencedFrameConfig URL attribute
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzerchromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <naskochromium.org>
Commit-Queue: Dominic Farolino <domchromium.org>
Cr-Commit-Position: refs/heads/main{#1147330}
--
wpt-commits: 4eab05e5e460d28219d324c13e5adcc94c5db109
wpt-pr: 40093
UltraBlame original commit: 3c5ecd4c7a60d1d2bb31f9ec7ceaf79a7c183a11
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 16, 2023
…a=testonly
Automatic update from web-platform-tests
Remove FencedFrameConfig URL attribute
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzerchromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <naskochromium.org>
Commit-Queue: Dominic Farolino <domchromium.org>
Cr-Commit-Position: refs/heads/main{#1147330}
--
wpt-commits: 4eab05e5e460d28219d324c13e5adcc94c5db109
wpt-pr: 40093
UltraBlame original commit: 3c5ecd4c7a60d1d2bb31f9ec7ceaf79a7c183a11
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…a=testonly
Automatic update from web-platform-tests
Remove FencedFrameConfig URL attribute
We're removing what we colloquially refer to as "default mode" in fenced
frames, which is where you manually construct a `new
FencedFrameConfig()` object with a (usually) non-opaque URL, to use
fenced frames without relying on cross-site data from FLEDGE or Shared
Storage. If a use-case that requires this mode of fenced frames presents
itself in the future, we will re-add it. But for now, this entails:
1. Removing the FencedFrameConfig#url IDL attribute
- Handled by this CL
- See corresponding spec change:
WICG/fenced-frame#88
2. Removing the FencedFrameConfig web-exposed constructor
- This will happen in a subsequent CL
We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage,
the URL member is always "opaque", since the true value depends on
cross-site data. An always "opaque"-returning attribute does not add any
value to web developers.
To carry out this change we must remove tests that rely on observing
the FencedFrameConfig#url attribute, as these tests will need to be
removed anyways when fully removing "default mode".
[1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface
R=gtanzer@chromium.org
Bug: 1123606
Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147330}
--
wpt-commits: 4eab05e5e460d28219d324c13e5adcc94c5db109
wpt-pr: 40093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supplements https://chromium-review.googlesource.com/c/chromium/src/+/4547401
Preview | Diff