这是indexloc提供的服务，不要输入任何密码
Skip to content

FencedFrameConfig IDL fixes #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2023
Merged

FencedFrameConfig IDL fixes #77

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a96e39c
update idl + references
Apr 18, 2023
9d6da15
fix up
Apr 18, 2023
cbe9d29
make getters nullable
Apr 18, 2023
8b9961e
Use this dfn
domfarolino Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 79 additions & 26 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,14 @@ Each <{fencedframe}> has a <dfn for=fencedframe>config</dfn>, which is either a
1. Let |url| be the [=URL record=] <code>about:blank</code>.

1. <a spec="HTML" lt="parse a URL">Parse</a> |element|'s [=fencedframe/config=]'s
[=fencedframeconfig/url=] relative to |element|'s [=Node/node document=]. If this is
successful, then set [=url=] to the <a spec="HTML">resulting URL record</a>.
[=fencedframeconfig/config=]'s [=fenced frame config/mapped url=]'s [=mapped url/value=]
relative to |element|'s [=Node/node document=]. If this is successful, then set [=url=] to the
<a spec="HTML">resulting URL record</a>.

1. [=Navigate=] |element|'s [=fenced navigable container/fenced navigable=] to |url| using
|element|'s [=Node/node document=], with [=historyHandling=] set to "<a for="history handling
behavior">`replace`</a>" , and [=referrerPolicy=] set to <a>"`no-referrer`"</a>.
<span class="XXX">TODO: generate and store the config instance</span>
</div>

<div algorithm=destroy>
Expand Down Expand Up @@ -578,7 +580,7 @@ A <dfn export>fenced frame config</dfn> is a struct with the following [=struct/
: <dfn>nested configs</dfn>
:: null, or a struct with the following fields:
: <dfn for="nested configs">value</dfn>
:: a sequence of [=fenced frame configs=]
:: a [=list=] of [=fenced frame configs=]

: <dfn for="nested configs">visibility</dfn>
:: a [=visibility=]
Expand Down Expand Up @@ -674,10 +676,18 @@ A <dfn export>fenced frame config instance</dfn> is a struct with the following
::
1. If |config|'s [=fenced frame config/nested configs=] is null, set to null.

1. Otherwise, set to an [=ordered map=], where for each [=fenced frame config=] in
|config|'s [=fenced frame config/nested configs=]'s [=nested configs/value=], there is
an entry where the key is a randomly sampled [=urn uuid=] and the value is the [=fenced
frame config=]. <span class=XXX>TODO: Write this in the proper syntax</span>
1. Otherwise:

1. Let |results| be an empty [=ordered map=].

1. [=list/For each=] |nested config| of |config|'s [=fenced frame config/nested
configs=]'s [=nested configs/value=]:

1. Let |urn| be a random, unique [=urn uuid=].

1. [=map/Set=] |results|[|urn|] to |nested config|.

1. Set [=fenced frame config instance/nested configs=] to |results|.

: [=fenced frame config instance/partition nonce=]
:: a random, unique [=partition nonce=]
Expand All @@ -699,44 +709,84 @@ maps to an internal [=fenced frame config=] [=struct=].

[Exposed=Window]
interface FencedFrameConfig {
constructor(USVString url);

readonly attribute FencedFrameConfigURL? url;
readonly attribute FencedFrameConfigSize? width;
readonly attribute FencedFrameConfigSize? height;
readonly attribute FencedFrameConfigSize? containerWidth;
readonly attribute FencedFrameConfigSize? containerHeight;
readonly attribute FencedFrameConfigSize? contentWidth;
readonly attribute FencedFrameConfigSize? contentHeight;

undefined setSharedStorageContext(DOMString contextString);
};
</pre>

Issue: Fix the "indistinguishable" IDL bug with the unions above.</span>

Each {{FencedFrameConfig}} has a <dfn for=fencedframeconfig>url</dfn>, which is a [=URL=].
Each {{FencedFrameConfig}} has two internal members: <dfn for=fencedframeconfig>urn</dfn>, which is a [=urn uuid=], and <dfn for=fencedframeconfig>config</dfn>, which is a [=fenced frame config=].

1. <span class=XXX>TODO: add more fields to {{FencedFrameConfig}}</span>
<span class=XXX>TODO: add more fields to {{FencedFrameConfig}}</span>

<div algorithm="url getter">
The {{FencedFrameConfig/url}} IDL attribute getter steps are:

1. <span class=XXX>TODO</span>
1. If {{FencedFrameConfig}}'s [=fencedframeconfig/config=]'s [=fenced frame config/mapped url=]'s
[=mapped url/visibility=] is [=visibility/transparent=], return the [=fenced frame config/
mapped url=]'s [=mapped url/value=].

1. Otherwise, return `"opaque"`.
</div>

<div algorithm="width getter">
The {{FencedFrameConfig/width}} IDL attribute getter steps are:
<div algorithm="containerWidth getter">
The {{FencedFrameConfig/containerWidth}} IDL attribute getter steps are:

1. <span class=XXX>TODO</span>
1. If [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/container size=] is null,
return null.

1. Return [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/container size=]'s
[=size/width=].
</div>

<div algorithm="height getter">
The {{FencedFrameConfig/height}} IDL attribute getter steps are:
<div algorithm="containerHeight getter">
The {{FencedFrameConfig/containerHeight}} IDL attribute getter steps are:

1. <span class=XXX>TODO</span>
1. If [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/container size=] is null,
return null.

1. Return [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/container size=]'s
[=size/height=].
</div>

<div algorithm="contentWidth getter">
The {{FencedFrameConfig/contentWidth}} IDL attribute getter steps are:

1. If [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/content size=] is null,
return null.

1. If [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/content size=]'s [=content
size/visibility=] is [=visibility/transparent=], return the [=fenced frame config/content
size=]'s [=content size/value=]'s [=size/width=].

1. Otherwise, return `"opaque"`.
</div>

<div algorithm="contentHeight getter">
The {{FencedFrameConfig/contentHeight}} IDL attribute getter steps are:

1. If [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/content size=] is null,
return null.

1. If [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/content size=]'s [=content
size/visibility=] is [=visibility/transparent=], return the [=fenced frame config/content
size=]'s [=content size/value=]'s [=size/height=].

1. Otherwise, return `"opaque"`.
</div>

<div algorithm>
The <dfn method for=FencedFrameConfig>setSharedStorageContext(contextString)</dfn> method steps are:
The <dfn method for=FencedFrameConfig>setSharedStorageContext(|contextString|)</dfn> method steps
are:

1. <span class=XXX>TODO</span>
1. Set [=this=]'s [=fencedframeconfig/config=]'s [=fenced frame config/embedder shared storage
context=] to |contextString|.
</div>

<h3 id=fence-interface>The {{Fence}} interface</h3>
Expand Down Expand Up @@ -769,7 +819,7 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.
</pre>

<div algorithm>
The <dfn method for=Fence>reportEvent(<var ignore>event</var>)</dfn> method steps are:
The <dfn method for=Fence>reportEvent(|event|)</dfn> method steps are:

1. Let |instance| be [=this=]'s [=relevant global object=]'s [=associated Document=]'s [=node
navigable=]'s [=navigable/traversable navigable=]'s [=fenced frame config instance=].
Expand All @@ -793,7 +843,7 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.
</div>

<div algorithm>
The <dfn method for=Fence>setReportEventDataForAutomaticBeacons(<var ignore>event</var>)</dfn>
The <dfn method for=Fence>setReportEventDataForAutomaticBeacons(|event|)</dfn>
method steps are:

1. Let |instance| be [=this=]'s [=relevant global object=]'s [=associated Document=]'s [=node
Expand All @@ -807,7 +857,7 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.

1. If |instance|'s [=fenced frame config instance/fenced frame reporter=] is null, then return.

1. Run [=set automatic beacon data=] with <var ignore>event</var> and |instance|'s
1. Run [=set automatic beacon data=] with |event| and |instance|'s
[=fenced frame config instance/fenced frame reporter=].
</div>

Expand All @@ -830,7 +880,10 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.
1. [=map/For each=] |urn| → |config| of |instance|'s [=fenced frame config instance/nested
configs=]:

1. <span class="XXX">TODO: construct a {{FencedFrameConfig}} from |config| and |urn|</span>.
1. [=list/Extend=] |results| with a {{FencedFrameConfig}} where the {{FencedFrameConfig}}'s
[=fencedframeconfig/urn=] is |urn| and the {{FencedFrameConfig}}'s [=fencedframeconfig/
config=] is |config|.
<span class="XXX">TODO: phrase the constructor correctly</span>.

1. Return |results|.
</div>
Expand Down