Add monkey patch for Cross-Origin Resource Policy Internal Check #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
requested changes
May 25, 2022
domfarolino
requested changes
May 25, 2022
domfarolino
approved these changes
Jun 2, 2022
domfarolino
requested changes
Jun 2, 2022
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
One more change, otherwise it looks good.
domfarolino
approved these changes
Jun 4, 2022
domfarolino
pushed a commit
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a monkey patch that modifies the CORP internal check to not short circuit allow for same-origin URLs if the request's destination is a fenced frame. This will ensure that fenced frames always act like cross-origin frames, regardless of the origin of its src attribute.