-
Notifications
You must be signed in to change notification settings - Fork 36
[Spec] Fix navigation from the default constructor not installing a fenced frame config. #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7d4c90d
Fix default constructor not instantiating fenced frame config
blu25 bb4343d
Update spec.bs
blu25 dc2158d
Merge branch 'master' into liam-default-config-navigate
blu25 449a598
cleanup
blu25 832bd5c
fix outdated naming
blu25 6f0eedc
address review comments
blu25 a2d6656
modify check to check ancestor navigables
blu25 076149e
address comments and add unfenced ancestor patch
blu25 a04d199
revert and add issue link
blu25 9205b85
remove inclusive ancestor navigables patch
blu25 3675ec4
Issue wording
domfarolino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.