Remove unused config size attributes #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IDL containerWidth, containerHeight, contentWidth, and contentHeight attributes not actually implemented in Chromuim, so we should remove them. Additionally, the internal fenced frame config struct does not implement container size, only content size. So we should remove that as well
Collaborator
|
Is this ready for review? |
Collaborator
Author
|
Yes, sorry! I don't think I have the proper permissions on the repo to add reviewers myself. |
domfarolino
approved these changes
Aug 25, 2024
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
Very nice, thanks for this cleanup!
Collaborator
|
Before I merge, can I ask @blu25 to take a quick look too? Just since you all are more familiar with the latest FF implementation than me at the moment. |
Collaborator
Author
|
Thanks for the review Dom! And yep, sounds good. |
blu25
reviewed
Aug 28, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 4, 2024
SHA: a8ec772 Reason: push, by blu25 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
VergeA
added a commit
to VergeA/fenced-frame
that referenced
this pull request
Sep 5, 2024
Follow-up to WICG#182 Along with the unused IDL size attributes, I also removed the internal fenced frame config container size definition. I was mistaken about it being vestigial (I missed a reference to it in the implementation when I was originally deciding to remove it, so I didn't see it was actively used). The Protected Audience spec depended on the field, and I broke their build: WICG/turtledove#1270 (comment) This change re-adds the container size definition to un-break things.
domfarolino
pushed a commit
that referenced
this pull request
Sep 5, 2024
Follow-up to #182 Along with the unused IDL size attributes, I also removed the internal fenced frame config container size definition. I was mistaken about it being vestigial (I missed a reference to it in the implementation when I was originally deciding to remove it, so I didn't see it was actively used). The Protected Audience spec depended on the field, and I broke their build: WICG/turtledove#1270 (comment) This change re-adds the container size definition to un-break things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDL containerWidth, containerHeight, contentWidth, and contentHeight attributes not actually implemented in Chromuim, so we should remove them.
Additionally, the internal fenced frame config struct does not implement container size, only content size. So we should remove that as well.
Preview | Diff