这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@blu25
Copy link
Collaborator

@blu25 blu25 commented Aug 19, 2024

The navigate algorithm has changed since we originally monkey patched it. This PR updates our monkey patch to reference the steps as they currently exist. This also cleans up the Should navigation response to navigation request be blocked by Permissions Policy? definition to match the formatting of other algorithms.

See issue: #179


Preview | Diff

@blu25 blu25 requested a review from domfarolino August 26, 2024 15:03
@domfarolino
Copy link
Collaborator

This also cleans up the Should navigation response to navigation request be blocked by Permissions Policy? definition to match the formatting of other algorithms.

Other algorithms in our spec, or in HTML? The current declaration of that algorithm seems pretty good / clear, what's wrong with it?

@blu25
Copy link
Collaborator Author

blu25 commented Aug 27, 2024

This also cleans up the Should navigation response to navigation request be blocked by Permissions Policy? definition to match the formatting of other algorithms.

Other algorithms in our spec, or in HTML? The current declaration of that algorithm seems pretty good / clear, what's wrong with it?

Most algorithms in our spec don't start with "Create a new algorithm called X..." but instead either just define the algorithm's name or state "To do X given Y, run these steps:". I think it's better for this algorithm to try to match the latter for consistency.

@blu25 blu25 self-assigned this Oct 17, 2024
@blu25 blu25 requested a review from domfarolino October 17, 2024 14:57
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some new rebase conflicts, can you resolve them?

@domfarolino domfarolino merged commit eae30ee into master Oct 31, 2024
2 checks passed
@domfarolino domfarolino deleted the liam-fix-navigation-numbers branch October 31, 2024 02:59
github-actions bot added a commit that referenced this pull request Oct 31, 2024
SHA: eae30ee
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants