这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@blu25
Copy link
Collaborator

@blu25 blu25 commented Aug 17, 2024

This CL does the following:

  • Specs out the "sandbox" attribute in the fencedframe element.
  • Specs out the fencedframe sandboxing flag set to match the iframe equivalent.
  • Specs out the behavior that ensures that a fenced frame's active sandboxing flag set is at least as restrictive as the fenced frame config's effective sandboxing flags.
  • Specs out the behavior that a fenced frame cannot load if the final sandboxing flag set is more restrictive than the effective sandboxing flags.

Follow-up PRs will need to be done for the following:

See issue: #155


Preview | Diff

@blu25 blu25 requested a review from domfarolino August 17, 2024 01:21
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good.

Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much lgtm % one comment about what looks like a stray random line of text

@domfarolino domfarolino merged commit 00676a5 into master Aug 26, 2024
@domfarolino domfarolino deleted the liam-sandbox branch August 26, 2024 21:18
github-actions bot added a commit that referenced this pull request Aug 26, 2024
SHA: 00676a5
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants