Fix failing build caused by stale reference #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
approved these changes
Jan 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Jan 19, 2024
SHA: d6a5a54 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the line that clears out automatic beacon data whose
once=Trueto use the new automatic beacon data map that was added in #133.One concern I have about this is whether or not the get the automatic beacon data mapping to use algorithm is building a map of references to or copies of the original mapping. If it's the latter, then we'll need to do further refactoring to make sure that the things in the various mappings can be modified by the "maybe send automatic beacon" algorithm.
Preview | Diff