Prevent reserved beacons from being sent manually. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
approved these changes
Dec 24, 2023
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
Let's just make sure the Protected Audience indeed makes use of this term so we don't accidentally export it for no reason.
github-actions bot
added a commit
that referenced
this pull request
Dec 24, 2023
SHA: feff58e Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Collaborator
Author
I just put up WICG/turtledove#968 for review which references this term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting an event through the
window.fence.reportEvent()call should not be allowed to work if it's passed in a "reserved." event type.This PR also exports
automatic beacon event type, which will be used by the TURTLEDOVE spec for a similar patch toregisterAdBeacon().Preview | Diff