这是indexloc提供的服务，不要输入任何密码
Skip to content

Spec adAuctionComponents #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 4, 2024
Merged

Spec adAuctionComponents #163

merged 11 commits into from
Jun 4, 2024

Conversation

@HabibiYou
Copy link
Contributor

@HabibiYou HabibiYou commented Jun 3, 2024 •
edited by pr-preview bot
Loading

domfarolino
domfarolino reviewed Jun 4, 2024
View reviewed changes
@HabibiYou HabibiYou requested a review from domfarolino June 4, 2024 17:16
domfarolino
domfarolino reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as #161 (review)

@JensenPaul
Copy link
Contributor

JensenPaul commented Jun 4, 2024

Same question as #161 (review)

I feel like adAuctionComponents() belongs here as it references only terms defined in the FF spec. Were it in the PA spec, it would have to cross-reference everything from the FF spec, and would hence be a bit non sequitur and lack relevant context for readers.

@domfarolino domfarolino merged commit 4966a9e into WICG:master Jun 4, 2024
github-actions bot added a commit that referenced this pull request Jun 4, 2024
@HabibiYou @github-actions
Spec adAuctionComponents (#163)
e230cef 
SHA: 4966a9e
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@brusshamilton brusshamilton mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domfarolino domfarolino domfarolino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HabibiYou @JensenPaul @domfarolino