Fix TODO for calling "on navigate callback" #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzer
reviewed
May 28, 2024
domfarolino
approved these changes
Jun 4, 2024
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
This looks good to me. The only usage of this appears to be https://wicg.github.io/turtledove/#ref-for-fenced-frame-config-on-navigate-callback%E2%91%A0, and https://wicg.github.io/turtledove/#asynchronously-finish-reporting indeed appears to expect to run in parallel, which is good. Just putting this down in writing for future archaeology if necessary.
|
|
||
| 1. Set |url| to |config|'s [=fenced frame config/mapped url=]'s [=mapped url/value=]. | ||
|
|
||
| 1. Run steps in |config|'s [=fenced frame config/on navigate callback=]. |
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. Run steps in |config|'s [=fenced frame config/on navigate callback=]. | |
| 1. Run the steps in |config|'s [=fenced frame config/on navigate callback=]. |
Collaborator
|
Thank you! |
github-actions bot
added a commit
that referenced
this pull request
Jun 4, 2024
SHA: cd9d57c Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff