Add specific click API details, plus a code example #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've solidified some of the API designs, we should have more details about them in the explainer where necessary. Getting from shared storage is pretty straightforward, but the click listener API needs an explicit description of its API surface. In addition, I've added an end-to-end example of how all of our API surfaces can be combined for a real-world use case of personalized payment buttons.
explainer/fenced_frames_with_local_unpartitioned_data_access.md
Outdated
Show resolved
Hide resolved
explainer/fenced_frames_with_local_unpartitioned_data_access.md
Outdated
Show resolved
Hide resolved
explainer/fenced_frames_with_local_unpartitioned_data_access.md
Outdated
Show resolved
Hide resolved
explainer/fenced_frames_with_local_unpartitioned_data_access.md
Outdated
Show resolved
Hide resolved
explainer/fenced_frames_with_local_unpartitioned_data_access.md
Outdated
Show resolved
Hide resolved
explainer/fenced_frames_with_local_unpartitioned_data_access.md
Outdated
Show resolved
Hide resolved
shivanigithub
approved these changes
Apr 12, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 12, 2024
SHA: 689776f Reason: push, by shivanigithub Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 23, 2024
The implementation of the onfencedtreeclick handler should now match the explainer and design doc content, as requested in WICG/fenced-frame#144 (comment) I have also flag-gated it properly, which I guess I forgot I could do before. Placing the attribute behind a flag should not introduce web-visible breakage, because the method that fires `fencedtreeclick` events (`window.fence.notifyEvent`) has not shipped. Bug: 336318606 Change-Id: Ie49f9a78da2dd80b7777a597c9640b598d5e2846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479607 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Andrew Verge <averge@chromium.org> Cr-Commit-Position: refs/heads/main@{#1291612}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've solidified some of the API designs, we should have more details about them in the explainer where necessary. Getting from shared storage is pretty straightforward, but the click listener API needs an explicit description of its API surface.
In addition, I've added an end-to-end example of how all of our API surfaces can be combined for a real-world use case of personalized payment buttons.