Add a non-normative use cases section #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Jan 25, 2024
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
A few suggestions, please fix the wrapping if the suggestions break that. (This seems to be a shortcoming of GitHub code suggestions).
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
domfarolino
reviewed
Feb 14, 2024
domfarolino
approved these changes
Mar 17, 2024
github-actions bot
added a commit
that referenced
this pull request
Mar 17, 2024
SHA: 5b3cdb6 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new "use cases" subsection to the "Fenced frame configs" section. This outlines 2 use cases (ad rendering + personalized payment button) and how it relates to the different ways to build a fenced frame config. They also go into privacy stories for both use cases.
I had also considered putting this in the main "Introduction" section, but decided it was both better to keep that section brief and to put this in a place where the concept of a "fenced frame config" had already been introduced.
Preview | Diff