-
Notifications
You must be signed in to change notification settings - Fork 36
Allow some fenced frames to inherit permissions #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I took another look at this after finding it my inbox. Feel free to resolve conflicts and formally re-request my review (so it appears in my dashboard) and I'll take another look at this PR. |
domfarolino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're just about there.
domfarolino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
See the "Permissions Changes" section of this document for details.
Fenced frames with unpartitioned data access need to be able to allow certain permissions policy-backed features (mainly Shared Storage) in order to function properly. This PR accomplishes that by allowing these fenced frames to inherit permissions policies the way that iframes do, but only allows a select list of permissions policies to be enabled. More specifically, this PR:
Derive a permissions policy directly from a fenced frame config instancein favor of a newCreate a permissions policy for a fenced navigablealgorithm, which handles both "fixed" and "flexible" permissions policies being created in a fenced frame.fencedparameter used when checking if navigation to a fenced frame should be blocked by permissions policy tomatches all. This is done to avoid confusion with theCreate a permissions policy for a fenced navigablealgorithm and to make it clear that the boolean specifically affects whether a permission will be inherited in the ultimately created permissions policy if the allowlist matches itself or just matches the wildcard*.Preview | Diff