这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@blu25
Copy link
Collaborator

@blu25 blu25 commented Jan 22, 2024

See the "Permissions Changes" section of this document for details.

Fenced frames with unpartitioned data access need to be able to allow certain permissions policy-backed features (mainly Shared Storage) in order to function properly. This PR accomplishes that by allowing these fenced frames to inherit permissions policies the way that iframes do, but only allows a select list of permissions policies to be enabled. More specifically, this PR:

  • Introduces the concept of a "fixed permissions policy" and "flexible permissions policy" in a FencedFrameConfig.
  • Removes Derive a permissions policy directly from a fenced frame config instance in favor of a new Create a permissions policy for a fenced navigable algorithm, which handles both "fixed" and "flexible" permissions policies being created in a fenced frame.
  • Renames the fenced parameter used when checking if navigation to a fenced frame should be blocked by permissions policy to matches all. This is done to avoid confusion with the Create a permissions policy for a fenced navigable algorithm and to make it clear that the boolean specifically affects whether a permission will be inherited in the ultimately created permissions policy if the allowlist matches itself or just matches the wildcard *.

Preview | Diff

@blu25 blu25 marked this pull request as ready for review January 22, 2024 18:12
@blu25 blu25 requested a review from domfarolino April 12, 2024 17:50
@domfarolino
Copy link
Collaborator

I took another look at this after finding it my inbox. Feel free to resolve conflicts and formally re-request my review (so it appears in my dashboard) and I'll take another look at this PR.

@blu25 blu25 requested a review from domfarolino September 30, 2024 17:51
@blu25 blu25 self-assigned this Oct 17, 2024
@blu25 blu25 requested a review from domfarolino December 6, 2024 23:18
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're just about there.

@blu25 blu25 requested a review from domfarolino December 11, 2024 19:26
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@domfarolino domfarolino merged commit e6288c1 into master Dec 11, 2024
2 checks passed
@domfarolino domfarolino deleted the liam-permissions-inheritance branch December 11, 2024 20:41
github-actions bot added a commit that referenced this pull request Dec 11, 2024
…ed `FencedFrameConfig`s (#140)

SHA: e6288c1
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants