Check that document is fully active for window.fence methods #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VergeA
reviewed
Jan 28, 2025
Collaborator
VergeA
left a comment
There was a problem hiding this comment.
One question, otherwise looks good.
VergeA
approved these changes
Jan 28, 2025
domfarolino
approved these changes
Jan 29, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2025
SHA: ef7eb0c Reason: push, by blu25 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes
window.fencemethods as they appear in the associated implementation.{{SecurityError}}check indisableUntrustedNetwork()to the newly added active document check.throwlink to the throw definition.Preview | Diff