Add spec for _unfencedTop navigation target. #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blu25
previously requested changes
Nov 12, 2024
domfarolino
reviewed
Nov 20, 2024
domfarolino
reviewed
Nov 21, 2024
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
LGTM % one tiny tiny comment!
I resolved all the requested changes in other comment threads.
domfarolino
approved these changes
Nov 21, 2024
Collaborator
domfarolino
left a comment
There was a problem hiding this comment.
Great, thanks a lot!
github-actions bot
added a commit
that referenced
this pull request
Nov 21, 2024
SHA: 01161ae Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of #174, converting the rough outline for the _unfencedTop navigation target spec into a formal patch.
Preview | Diff