WIP: spec: update in parallel steps to resolve or reject in tasks #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d76ae42 to
e31a0e9
Compare
Member
Author
|
tidoust: Can you review this? If it looks good, i'll update other algorithms in a similar way. |
tidoust
reviewed
Oct 2, 2024
Contributor
tidoust
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing. See inline for suggestions for improvement.
Co-authored-by: François Daoust <fd@tidoust.net>
99c5e70 to
d140c86
Compare
Member
Author
|
@tidoust can you do another pass? |
tidoust
approved these changes
Nov 7, 2024
Contributor
tidoust
left a comment
There was a problem hiding this comment.
Minor nit. Looks goot to me otherwise!
Co-authored-by: François Daoust <fd@tidoust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff