Flex windows #742
Merged
Flex windows #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac63c02 to
d9bcac0
Compare
apasel422
requested changes
Mar 29, 2023
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
approved these changes
Mar 30, 2023
|
Thanks, will hold off on landing until we validate that the impl is feasible. |
apasel422
added a commit
to apasel422/attribution-reporting-api
that referenced
this pull request
Sep 6, 2023
By removing only elements that were greater than eventReportWindow, this algorithm would have erroneously placed duplicate values in the deadlines list if the eventReportWindow was exactly 2 days or 7 days. In turn, this would have caused the returned windows list to contain 1 extra window. This seems to have been an oversight in WICG#742.
apasel422
added a commit
that referenced
this pull request
Sep 8, 2023
…thm (#992) By removing only elements that were greater than eventReportWindow, this algorithm would have erroneously placed duplicate values in the deadlines list if the eventReportWindow was exactly 2 days or 7 days. In turn, this would have caused the returned windows list to contain 1 extra window. This seems to have been an oversight in #742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734. Will still need to check complexity on the implementation side but I think this should fully specify the FR.
Preview | Diff