这是indexloc提供的服务,不要输入任何密码
Skip to content

Update explainer and spec to support multiple destinations #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2022

Conversation

csharrison
Copy link
Collaborator

@csharrison csharrison commented Nov 4, 2022

Fixes #44 as far as I can tell. This PR attempts to be a fully backwards compatible change, so existing deployments will not have to update any code to accomodate.

Addresses #549, not calling it fixed until further verification.


Preview | Diff

@csharrison csharrison marked this pull request as ready for review November 4, 2022 15:47
csharrison and others added 2 commits November 4, 2022 11:05
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
@csharrison csharrison requested a review from apasel422 November 4, 2022 21:45
@apasel422
Copy link
Collaborator

@csharrison Would it be possible for you to update the header validator in this PR as well? If not, I can do it in a followup.

@csharrison
Copy link
Collaborator Author

@csharrison Would it be possible for you to update the header validator in this PR as well? If not, I can do it in a followup.

Done

Copy link
Contributor

@johnivdel johnivdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

@csharrison csharrison requested a review from johnivdel November 7, 2022 18:22
Copy link
Contributor

@johnivdel johnivdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversions coming from a different domain than landing page
3 participants