Remove landing page restriction for navigation sources #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnivdel
reviewed
Oct 26, 2022
| @@ -173,9 +173,6 @@ to set the [=navigation params/attribution source=] of |navigationParams| to |at | |||
|
|
|||
| <h4 id="monkeypatch-document-creation">Document creation</h4> | |||
|
|
|||
| At the time <a spec="html">create and initialize a <code>Document</code> object</a> is invoked, the user agent knows the final URL used for the | |||
There was a problem hiding this comment.
I think most likely all of this routing through navigate steps can be ripped out, but given the attributionsrc= side isn't implemented in the draft spec, I think this state is fine for now.
apasel422
approved these changes
Oct 26, 2022
johnivdel
added a commit
that referenced
this pull request
Nov 4, 2022
With destination matching removed from the core web APIs(#592), we do not need to mirror it for cross app and web sources.
apasel422
pushed a commit
that referenced
this pull request
Nov 7, 2022
With destination matching removed from the core web APIs(#592), we do not need to mirror it for cross app and web sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590
Preview | Diff