Reduce dependency on Bluebird #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Gah, CI seems to be down. Submitted #50 to have a fallback |
Collaborator
|
Circle CI is now setup. You could try to rebase this to see if it runs automatically for all the PRs now. |
Contributor
Author
|
@elhigu Not until it is enabled from CircleCI side. I could do that if I had admin access, or you can go to circleci and authenticate via GitHub |
Contributor
Author
|
Ah, it is already running on master, so I assume you did the setup already. Awesome! I'll sync the branch. |
…remove-bluebird-1
Contributor
Author
|
@elhigu For some reason it triggers on master but not for branches. Is execution on branches enabled from CircleCI side? |
Collaborator
|
now it should be enabled also for forked PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the only remaining part that still uses Bluebird is .reflect part, will require some more tinkering to remove all of it.