这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@VictorAvelar
Copy link
Owner

Description

  • Adds a fixed type (SortDirection) for sorting values when retrieving lists.
  • Adds a method to the PaymentListsService that retrieves a list of payments associated with a unique payment link.

Other

  • Removes deprecated flags from golangci-lint used in the Taskfile.yaml.

Motivation and context

Closes #431

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

  • Unit tests added / updated
  • The tests run on docker (using task test)
  • The required test data has been added / updated

If you are running the tests locally, please specify:

  • OS: macos Sonoma
  • Go version: 1.24

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • If my change requires a change to the documentation, I have updated it accordingly.

@VictorAvelar VictorAvelar self-assigned this Feb 22, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation labels Feb 22, 2025
@VictorAvelar VictorAvelar added API parity Changes and features missing in the client valid for the v2 API area/payment-links labels Feb 22, 2025
@VictorAvelar VictorAvelar merged commit 53a000d into master Feb 22, 2025
10 checks passed
@VictorAvelar VictorAvelar deleted the add-payment-links-payments-list-method branch February 22, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API parity Changes and features missing in the client valid for the v2 API area/payment-links core documentation Improvements or additions to documentation testdata tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing api route for getting payments of a payment link

2 participants