Make changes to the github actions pipeline. #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .github/workflows/main.yml: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/linter.yml:44
- The linter workflow now uses '1.x' instead of '1.23.X'. Please confirm that this change was intentional and that it aligns with the desired Go environment for linting.
go-version: 1.x
.github/workflows/documentation-links.yml:1
- [nitpick] Consider adding a descriptive job name for the documentation links workflow to improve clarity in workflow runs.
on:
.github/workflows/codeql-analysis.yml:16
- [nitpick] Confirm if the removal of the pull_request trigger for CodeQL Analysis is intentional; if not, consider reinstating it to enable analysis on pull requests.
pull_request trigger block removed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the GitHub Actions workflows to consolidate testing and linting, update Go version management, and simplify configurations for documentation and code analysis.
- Replaces the old main.yml with a new tests.yml that adds concurrency controls and an updated Go version matrix.
- Renames golangci-lint.yml to linter.yml, using a flexible Go version specification.
- Simplifies workflows by removing redundant trigger configurations in documentation-links.yml and codeql-analysis.yml.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/tests.yml | Introduces a new testing workflow with concurrency and a revised Go matrix. |
| .github/workflows/main.yml | Removed in favor of the new tests.yml workflow. |
| .github/workflows/linter.yml | Renames and updates the Go version configuration for linting. |
| .github/workflows/documentation-links.yml | Removes the workflow name field to simplify configuration. |
| .github/workflows/codeql-analysis.yml | Removes the pull_request trigger, retaining only the scheduled trigger. |
Comments suppressed due to low confidence (3)
.github/workflows/documentation-links.yml:1
- [nitpick] Removing the workflow name field can affect clarity in the Actions run logs; consider if a descriptive name might still be beneficial for identifying the workflow in the interface.
-name: "Check docs links"
.github/workflows/tests.yml:43
- The Go version matrix now includes '1.x' and '1.23.x'; please confirm that this change is intentional compared to the previous matrix, which featured '1.23.x' and '1.24.x'.
go: [1.x, 1.23.x]
.github/workflows/linter.yml:44
- Review whether using the flexible '1.x' version for Go meets your version stability requirements since it may introduce unexpected toolchain changes over time.
go-version: 1.x
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request streamlines the GitHub Actions workflows by replacing and consolidating testing and linting pipelines while updating configuration details. Key changes include:
- Removal of the legacy main.yml workflow and introduction of tests.yml with concurrency controls and a Go version matrix.
- Renaming and updating of the linter workflow to use a flexible Go version specification.
- Simplification of the documentation-links workflow and removal of pull_request triggers from the codeql-analysis workflow.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Minor formatting change for the accepted payments list |
| .github/workflows/tests.yml | New testing workflow file with concurrency and matrix settings |
| .github/workflows/main.yml | Removal of the outdated testing workflow |
| .github/workflows/linter.yml | Updated Go version specification in the linting workflow |
| .github/workflows/documentation-links.yml | Simplified workflow by removing the name field |
| .github/workflows/codeql-analysis.yml | Removed pull_request trigger to keep only scheduled analysis |
| [](https://bestpractices.coreinfrastructure.org/projects/3522) | ||
|
|
||
| Accepting [iDEAL](https://www.mollie.com/payments/ideal/), [Apple Pay](https://www.mollie.com/payments/apple-pay), [Bancontact](https://www.mollie.com/payments/bancontact/), [SOFORT Banking](https://www.mollie.com/payments/sofort/), [Creditcard](https://www.mollie.com/payments/credit-card/), [SEPA Bank transfer](https://www.mollie.com/payments/bank-transfer/), [SEPA Direct debit](https://www.mollie.com/payments/direct-debit/), [PayPal](https://www.mollie.com/payments/paypal/), [Belfius Direct Net](https://www.mollie.com/payments/belfius/), [KBC/CBC](https://www.mollie.com/payments/kbc-cbc/), [paysafecard](https://www.mollie.com/payments/paysafecard/), [Giftcards](https://www.mollie.com/payments/gift-cards/), [Giropay](https://www.mollie.com/payments/giropay/), [EPS](https://www.mollie.com/payments/eps/) and [Przelewy24](https://www.mollie.com/payments/przelewy24/) online payments without fixed monthly costs or any punishing registration procedures. Just use the Mollie API to receive payments directly on your website or easily refund transactions to your customers. | ||
| Accepting [iDEAL](https://www.mollie.com/payments/ideal/), [Apple Pay](https://www.mollie.com/payments/apple-pay), [Bancontact](https://www.mollie.com/payments/bancontact/), [SOFORT Banking](https://www.mollie.com/payments/sofort/), [Creditcard](https://www.mollie.com/payments/credit-card/), [SEPA Bank transfer](https://www.mollie.com/payments/bank-transfer/), [SEPA Direct debit](https://www.mollie.com/payments/direct-debit/), [PayPal](https://www.mollie.com/payments/paypal/), [Belfius Direct Net](https://www.mollie.com/payments/belfius/), [KBC/CBC](https://www.mollie.com/payments/kbc-cbc/), [paysafecard](https://www.mollie.com/payments/paysafecard/), [Giftcards](https://www.mollie.com/payments/gift-cards/), [EPS](https://www.mollie.com/payments/eps/) and [Przelewy24](https://www.mollie.com/payments/przelewy24/) online payments without fixed monthly costs or any punishing registration procedures. Just use the Mollie API to receive payments directly on your website or easily refund transactions to your customers. |
There was a problem hiding this comment.
[nitpick] The removal of the list bullet marker appears to be a formatting change. To maintain consistency across the document, confirm that this change aligns with the intended style for all list items in README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the GitHub Actions workflows, including renaming files, consolidating workflows, and updating configurations. The most important updates involve the restructuring of workflows for testing and linting, as well as simplifying Go version management.
Workflow restructuring:
The
main.ymlworkflow has been removed, and its functionality has been replaced by a newtests.ymlworkflow. The new workflow includes concurrency controls, Go version matrix testing, and a streamlined configuration for running tests. ([[1]](https://github.com/VictorAvelar/mollie-api-go/pull/444/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3L1-L43),[[2]](https://github.com/VictorAvelar/mollie-api-go/pull/444/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR1-R63))The
golangci-lint.ymlworkflow has been renamed tolinter.ymland updated to use a more flexible Go version specification (1.xinstead of1.23.X). ([[1]](https://github.com/VictorAvelar/mollie-api-go/pull/444/files#diff-ba16fc050e9c818b8125acc6d33b13f4c427ca91373d286af13d0fc92da90605L1),[[2]](https://github.com/VictorAvelar/mollie-api-go/pull/444/files#diff-ba16fc050e9c818b8125acc6d33b13f4c427ca91373d286af13d0fc92da90605L45-R44))Workflow removals and simplifications:
The
documentation-links.ymlworkflow has been simplified by removing its name field while retaining its functionality. ([.github/workflows/documentation-links.ymlL1-L2](https://github.com/VictorAvelar/mollie-api-go/pull/444/files#diff-db385bef49fd7ab6efc0338151a618fc693503d724ed03c2555c5ea62a1ef474L1-L2))The
codeql-analysis.ymlworkflow has been updated by removing thepull_requesttrigger and its associatedpaths-ignoreandbranchesconfigurations, leaving only the scheduled trigger. ([.github/workflows/codeql-analysis.ymlL19-L34](https://github.com/VictorAvelar/mollie-api-go/pull/444/files#diff-63bd641104d10e25f141d518a16b22a151d125e12701df2f9e79734b23b90188L19-L34))