Add menu item options into config #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request Vidhyadharan24#6 from crspybits/master: Update from main repo
Contributor
Author
|
This should resolve: #5 |
Owner
|
@crspybits that's a lot of work, I will have a look at it. |
Contributor
Author
|
Happy to answer any questions you might have about this PR. I'm actively using my changed fork of your repo in https://apps.apple.com/us/app/neebla/id1244482164 (and see https://github.com/SyncServerII/Neebla/). Would be happy to switch back to this repo if this was merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client apps can now either (a) supply their own menu icons, or (b) entirely use their own icons and actions (through use of the
..navigationBarItemsmodifier).I refactored the code some too. Sorry it was a fairly large refactor as Xcode/SwiftUI was causing me difficulties and it made debugging the problem easier to split things out into more independent View's. I think it does, however, improve readability.
This should (hopefully!) be a non-breaking change. Other applications using this package should still work with no change.