Add UTC #3530
Open
Add UTC #3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should probably be a part of themeattributes instead |
|
sure, the only thing that matters is so should I change location or wait for someone else to review first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UTC (Universal Theming Classes) that appends stable class names [For example
utc_xyz] to elements, so theme devs don’t have to worry about class rerolls, only structural changes.Helps with theming by removing the need for wildcard selectors, which also improves performance.
The idea is to get it adopted across other client mods too, to make theming easier and consistent. Already PR'ed at replugged