这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: vehicle simulation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 19, 2024
Merged

feat: vehicle simulation #9

merged 12 commits into from
Aug 19, 2024

Conversation

jolexxa
Copy link
Member

@jolexxa jolexxa commented Aug 8, 2024

Description

Updates the project to use a simplified vehicle simulation model.

  • friction / rolling resistance / drag
  • top speed
  • smooth tachometer
  • automatic transmission
  • update widgets to use simulation model
  • update tests
  • physically based acceleration/deceleration model
2024-08-13.16.09.04.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)

@jolexxa jolexxa marked this pull request as ready for review August 13, 2024 20:58
@jolexxa jolexxa requested a review from marwfair August 13, 2024 21:12
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just had one small comment.

import 'package:equatable/equatable.dart';

/// Gravity constant in ft/s^2.
const kGravityFtS2 = 32.174;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If we want to stay consistent with Effective Dart, avoid prefix letters.
https://dart.dev/effective-dart/style#dont-use-prefix-letters

Suggested change
const kGravityFtS2 = 32.174;
const gravityFtS2 = 32.174;

@jolexxa jolexxa merged commit 6713d52 into main Aug 19, 2024
3 checks passed
@jolexxa jolexxa deleted the feat/vehicle-sim branch August 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants