-
Notifications
You must be signed in to change notification settings - Fork 2
Added new demo project, CachedPathSuggestBoxDemo. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactored DirectorySuggestionSource. Added LiteDb repository, LiteRepository, for storing paths to reuse.
Hi,
The odd thing is that I cannot see a suggestion when I enter a 'F' character (I have a 'F' drive). Is this as designed? Can you describe some test steps to explain how this demo should work please? |
…ches based on FullName. Cached data is returned in descending order of search time. Divided classes into separate files.
Centered textblocks
Yes it was by design, because i wanted to limit the results returned (and provide more relevant results?) i only matched on the name of the path rather than the full-name. However since that's probably not intuitive, i've changed (in my latest commit, today) for it to match on the full-name and only return the latest 5 results. Hopefully the logic is clearer as i broken things into separate files and added an interface, ISuggest. |
Hi, I have saved the following folders: Now I get these suggestion when I type: 'doc' (returns 1st entry) or 'com' returns 2nd entry So, I understand that you are matching on the last part of the path (name of path). But this matching does not seem to work because when I type 4 letters 'docu' or 'come' I get no results returned :-( I tried to fix this but I am not familiar with LiteDB so I am having a hard time putting together the right LinQ queries here :-( In my view, the best and most intuitive solution would be if the engine could:
Query: 'C' returns both entries since they contain the character 'c' Would you please be able to adjust it for query/response patterns outlined in 1) and 2)? I would also do some more work like putting a horizontal line between the suggestions from previous entries and the suggestions from the file system, and maybe writting some textbox text into the demo client so users know what to enter here. But I can do this after accepting the PR and its just some eye candy to make things interesting for users running the demo ... |
…cating functionality. Fixes issue with PathInformation returning an empty string if the path ended with \\. Combined two ISuggest classes into CombinedSuggest.
Perfect. Thanks a lot for this great example - I really like it :-) - I'll be trying to improve the visual throughout the next week and will get back to you when I have something worthwhile to show… Thanx Drk |
Hi, |
Yes, please go ahead and feel free to improve the architecture were you see room for improvement. I got this from another hot shot developer @lycj who lives (coding-wise) on a level that I normally can't dare to enter or am not that interested to find out about all the details - but since I refactored it I can answer a few questions about it and should you find bugs or have any questions feel free to ask :-) I guess you've seen this and want to improve it with a search capability? I'm learning a bit from your code too. Never used these One question: How did you get the Data folder to be present but not being part of the commit? |
I've refactored your sample into an MVVM approach and inserted a separator between bookmarked suggestions and the suggestions from the file system (and added in code documentation). There is only one thing I cannot get resolved :-( The Do you know the correct delete statement for the case of inserting the same string twice? I also added a Remove (button see below) but cannot make it functional because I cannot delete anything :-( |
Hi
I was interested in the SuggestBox control but wanted to also cached paths for reuse.
So, i created a new demo where i make use of two suggestion-provider classes, DirectorySuggestionSource and a new one, SuggestionProvider, and combined their results.
Also refactored DirectorySuggestionSource.
Added LiteDb repository, LiteRepository, for storing paths to reuse.