Add anchorable hide and close notifications to DockingManager #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds close and hide events to DockingManager for anchorables. This brings anchorables inline with documents (LayoutDocument) as documents already have this functionality in DockingManager.
The reason for this change is so I can use a custom PrismLibrary region adapter for DockingManager. A PrismLibrary region adapter needs to track when controls are visibly removed from a parent, which in this case is DockingManager. Sample region adapters for other parent panels can be found in this repo.
This code is a port from a custom version of the old AvalonDock that I have been using with PrismLibrary for many years. I have added unit tests for the new functionality.