这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix right click context menu bug #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix right click context menu bug #245

merged 1 commit into from
Feb 25, 2021

Conversation

oatkins
Copy link
Contributor

@oatkins oatkins commented Feb 23, 2021

Fixes #244.

@oatkins oatkins marked this pull request as ready for review February 23, 2021 21:12
@oatkins oatkins force-pushed the fix-right-click-close branch from 833aeae to a55d7c9 Compare February 23, 2021 21:30
Dirkster99
Dirkster99 reviewed Feb 24, 2021
View reviewed changes
Copy link
Owner

@Dirkster99 Dirkster99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change causes a syntax error in line 47 of the DropDownControlArea class because there is an extra/not needed #endregion statement. Does the code change have the intended effect if you remove the #endregion statement (the code compiles and looks to work normal to me).

@Dirkster99
Copy link
Owner

Hi Olly, your fix looks OK for me and I am happy to merge it but there is an error in the DropDownControlArea class in your branch. There is one #endregion too many after the ctors region:

		#endregion ctors

#endregion

		#region Properties

@oatkins oatkins force-pushed the fix-right-click-close branch from a55d7c9 to 83a9a15 Compare February 24, 2021 20:53
@oatkins
Copy link
Contributor Author

oatkins commented Feb 24, 2021

Hi Olly, your fix looks OK for me and I am happy to merge it but there is an error in the DropDownControlArea class in your branch. There is one #endregion too many after the ctors region:

		#endregion ctors

#endregion

		#region Properties

Hello! Sorry about that. Silly mistake: I forgot to check the code built after rebasing it onto the new version you released yesterday. How does this look now?

Incidentally, I hope to have one or two more small fixes or enhancements on the way. I had these in a customised version of the Xceed code, but, since I'm moving to your version, I hope I can share them in case they're useful to others too.

Thanks for taking a look at this so quickly.

@Dirkster99 Dirkster99 merged commit 9665e8f into Dirkster99:master Feb 25, 2021
@oatkins oatkins deleted the fix-right-click-close branch April 26, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirkster99 Dirkster99 Dirkster99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right click on tab header closes tab unexpectedly
2 participants
@oatkins @Dirkster99