Raise PropertyChanged notification when LayoutContent.IsFloating changes #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi Boris, I was not aware of the case that the IsFloating property is not always changed when the Documents state changes. Thanks for your input as this should help close another of these gaps :-) |
Contributor
Author
|
Well if you check the code IsFloating property is read-only and value is calculated in getter so in most cases it will be fine. It is just bindings that won't sense its changes without these notifications. :) |
Owner
|
I see what you mean and added a tag to mark this as bindable. I guess I should add this to pretty much all properties in the LayoutContent class (for sure to those that implement the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dirk, that's first of series of small and hopefully safe PRs that I plan to do for changes in our fork to synchronize with main.
In this one we raise PropertyChanged for IsFloating property of LayoutContent which is read-only and indirectly changed when layout element is made floating or docked back to main window.
In our project there are places where we have bindings to IsFloating and they don't work as expected due to notifications not being sent.