Fix #182 #183
Merged
Fix #182 #183
+1,575
−1,562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… VS2013 theme and override CanClose property metadata of LayoutAnchorableItem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed fix overrides the metadata of LayoutAnchorableItem.CanCloseProperty to match the default value of False with its LayoutAnchorable. The fix also includes adding missing triggers on the VS2013 theme for showing the Close button on the LayoutAnchorableTitlePane and LayoutAnchorableFloatingWindow.
Visual Studio apparently replaced the tabs with spaces, resulting in the unnecessarily large addition/removal which I unfortunately can't do anything about. The actual changes in Generic.xaml are lines 680-683 and 2037-2040.