这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@eriove
Copy link
Contributor

@eriove eriove commented Apr 9, 2020

Added resources from DockingManager to the LayoutFloatingWindowControl, this makes the styles work as expected (i.e. as your example here).

@Dirkster99 Do you think this is a good addition? Personally I think it will really help users, the typical WPF behavior is that resources applied to a control will be will be used. I wonder if there is another way of doing it? Are there more controls that need the same change?

@Dirkster99 Dirkster99 closed this Apr 9, 2020
@Dirkster99
Copy link
Owner

I am not sure about this additional
Resources.MergedDictionaries.Add(model.Root.Manager.Resources);

statement. Why would we need it and what is the test case it would resolve?

So far, I've been using this with several different styles and I've never needed the above statement so I'd rather think we should leave this as it is (?)

@eriove
Copy link
Contributor Author

eriove commented Apr 14, 2020

Resources.MergedDictionaries.Add(model.Root.Manager.Resources); makes it possible to add styles directly where the DockingManager control is added to the UI (in any XAML-file) instead of adding it in App.xaml or a resource file.

I don't really need that. It was the first way I thought of adding the style. I'll push an example to this branch tonight. It is probably not worth merging.

@eriove
Copy link
Contributor Author

eriove commented Apr 15, 2020

@Dirkster99 Here's the example that becomes possible when merging the dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants