-
Notifications
You must be signed in to change notification settings - Fork 337
support netcore3 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support netcore3 #65
Conversation
|
you don't use a appveyor yml file atm. so I don't know how to fix build. I use this in my appveyor yml: |
|
And if youd like to use csproj for the nuget build : |
|
but for the csproj patch to work, the version xml elements have to be in the csproj files (i've not added them atm) |
|
The yml file is now part of the master branch: |
|
now maybe it should work. you can adjust the version in the appveyor.yml and if you'd like enable nuget publish |
|
Cool this works with Appveyor :-) I was actually looking for this integration for some time but found no hint about the choco trick - thanks for that. I am currently installing and will be looking at the branch this weekend, and hopefully, sometime next week we can get this into the master branch out of the door :-) |
|
I've removed the AssemblyVersion Attributes from the csharp files, cause I added the Version to csproj. |
|
The Nuget's should now also be added to the artifacts with my last commit. So now you can decide, add them manualy or upload them directly by changeing appveyor.yml |
|
ok, now i'm finished. nugets work, demo app works in netcore3 done. |
|
Yep. I just gave it some tests and its looking really good :-) So, if I increase the version to say 3.5.12 I am setting this in the tag of the csproj file (right?): <AssemblyVersion>1.0.0.0</AssemblyVersion>
<FileVersion>1.0.0.0</FileVersion>I saw that you ported TestApp. I would also like to port the other demo projects but to do this I have to port all dependent control projects first, right? I guess, I'll look at that as soon as this is on master which will be very soon thanx to your cool PR :-) |
|
yes, but at the moment appveyor oberwrites the csproj version. |
|
I think netcore could also use some wpf packages directly, but dont know why |
No description provided.