PrintTree and RoundTree: use Layout instead of &Layout #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Woops, forgot to update the examples. Will do that. |
nicoburns
requested changes
Jun 25, 2025
Collaborator
nicoburns
left a comment
There was a problem hiding this comment.
I definitely want to enable the RefCell use case. And the logic around rounding and printing makes sense to me. However, for TaffyTree I believe these methods are currently the only way to access the computed layout and I think we'd still want a way to access by reference there (as 84 bytes is kinda bigish to be copying around).
So could we either:
- Add inherent methods to
TaffyTreeto get layout by ref - Or add associated types so that we can return
impl Deref<Target = Layout>
?
nicoburns
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR allows the use of
PrintTreeandRoundTreefor smart pointer interfaced trees.Let me know how is best to update the changelog if you need me to.
Context
In my use of taffy, I need my tree implementation to be within a
RefCell<T>. This is already possible with most tree traits, as they have generic associated types implementing traits such asCoreStyle, so I can make a newtype overRef<'a, Style>withRef::mapand make it work. However,RoundTreeandPrintTreedo not allow this, as they return a plain&Layoutreference instead of an associated type.I looked in the code, and in the tree rounding code, the
&Layoutis already copied. Additionally, printing the tree is likely more of a debugging or testing feature, so I feel that copying is warranted here instead of having to introduce some sort of new trait likeCoreStyleforLayoutwhich would potentially break more code internally.