fix: removed wrong addition, causing items to be misplaced. #817
Conversation
|
Can you add a test for this? This seems like a reasonable fix, but regression tests are good, since this is clearly an edge case we weren't testing. |
There was a problem hiding this comment.
Thanks for looking into this! (and thanks for the test).
It looks the fundamental issue here is that the original code gets the "primary" and "secondary" axes mixed up. This code ought to be incrementing the secondary axis (in some cases) but it's actually incrementing the primary axis. I'm guessing this wasn't caught before because layouts that fix the "primary" axis but use auto-placement for the secondary axis are relatively rare.
I'm inclined to accept this as it's a definite improvement on what we have, but there will be some follow-up required to make this completely correct.
Objective
This fixes a case where a grid item on the primary axis would get put into a wrong track.
Context
This came up in this issue DioxusLabs/blitz#187
Where a gird looked like this
(with commit)
