这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Jul 7, 2024

Objective

Context

  • The web has two box sizing modes that modify how size styles affect a node's size: box-sizing: border-box and box-sizing: content-box. Taffy has previously assumed box-sizing: border-box, and while that's generally a good default, box-sizing: content-box is actually the default on the web, and is thus crucial for web compatibility.
  • This is breaking change (due to a new style being added). So we may want to put out a patch release before merging.

@nicoburns nicoburns added enhancement New feature or request breaking-change A change that breaks our public interface labels Jul 7, 2024
@nicoburns nicoburns force-pushed the box-sizing-content-box branch 3 times, most recently from dbeaaae to f4c853d Compare July 7, 2024 10:15
@nicoburns
Copy link
Collaborator Author

Hmm... this seems to be causing benchmark regressions in the ~15% range for CSS Grid. Will need to look into this.

@nicoburns nicoburns force-pushed the box-sizing-content-box branch 4 times, most recently from 5fdc23d to 8736954 Compare July 11, 2024 22:51
@nicoburns nicoburns force-pushed the box-sizing-content-box branch from 8736954 to e56561b Compare July 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A change that breaks our public interface enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document that Taffy uses box-sizing: border-box Support box-sizing: content-box

1 participant