这是indexloc提供的服务，不要输入任何密码
Skip to content

Ensure that root flexbox node sizes are floored by their padding border #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2024
Merged

Ensure that root flexbox node sizes are floored by their padding border #655

merged 2 commits into from
May 14, 2024

Conversation

@nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented May 13, 2024 •
edited
Loading

Objective

Notes

  • This bug only seems to affect nodes that happen to be the root of the tree.

Changes made from #651

  • Test moved to tests/root_constraints
  • Fix changed so that override does not apply to known_dimensions
  • A generated test covering this case added
  • Removed import of Add trait (uses + syntax rather than calling .add so it isn't needed)

@nicoburns nicoburns added the bug Something isn't working label May 13, 2024
@nicoburns nicoburns force-pushed the flexbox-root-padding-border-fixes branch from f5c627a to 090fec8 Compare May 13, 2024 13:43
@nicoburns nicoburns force-pushed the flexbox-root-padding-border-fixes branch 2 times, most recently from 33b4a98 to 5da6960 Compare May 13, 2024 13:50
@nicoburns @julia-script
Ensure that root flexbox node sizes are floored by their padding border
dda47e2 
Co-authored-by: Julia Ortiz <contato@juliaortiz.com.br>
@nicoburns nicoburns force-pushed the flexbox-root-padding-border-fixes branch from 5da6960 to dda47e2 Compare May 13, 2024 13:54
@alice-i-cecile alice-i-cecile mentioned this pull request May 13, 2024
Closed
@nicoburns nicoburns merged commit c154b8a into DioxusLabs:main May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicoburns @julia-script