evenly_sized_tracks - fix simple compile error #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flex's argument needs to be Into<f32>, a plain float literal is f64 which does not work, I just specified that the argument here is f32
|
https://github.com/bevyengine/bevy/actions/runs/8656168577/job/23736270747?pr=12923#step:6:636 this is causing an error in CI for taffy apparently aswell |
Collaborator
|
This seems uncontroversial, although it won't fix 3rd-party code that's calling this API and relying on type inference. I guess this should probably to be backported to the 0.3.x series seeing as Bevy is still using that. |
|
Bevy is currently unusable, all compatible versions 0.3.10 to 0.3.18 are broken. |
nicoburns
pushed a commit
to nicoburns/taffy
that referenced
this pull request
Apr 12, 2024
flex's argument needs to be Into<f32>, a plain float literal is f64 which does not work, I just specified that the argument here is f32 (cherry picked from commit 9f27870)
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flex's argument needs to be Into f32, a plain float literal is f64 which does not work, I just specified that the argument here is f32
Objective
fixes #642