Fix implementation of SizingMode::ContentSize for Flexbox, Grid, and Block algorithms
#576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fd0fd6 to
516fe71
Compare
alice-i-cecile
approved these changes
Nov 2, 2023
Collaborator
alice-i-cecile
left a comment
There was a problem hiding this comment.
Terrible. Approved!
nicoburns
added a commit
to nicoburns/taffy
that referenced
this pull request
Nov 2, 2023
Merged
nicoburns
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Context
Flexbox has an annoying exception to the usual sizing rules where in some cases it requires a node to size itself while ignoring it's preferred width and height styles. This was previously only implemented for leaf nodes.