这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Jun 15, 2023

Objective

  • Support layout of padding, borders, and scrollbars gutters on leaf nodes

Context

Fixes issue with Bevy's new border support drawing borders on top of images.

Notes

Blocked on #496. But can be merged as soon as that one is. #496 is now merged

@nicoburns nicoburns added bug Something isn't working blocked Cannot be advanced until something else changes labels Jun 15, 2023
@nicoburns nicoburns force-pushed the fix/padding-border-scrollbar-with-measure branch from 09338c1 to 6c0f49a Compare June 15, 2023 17:25
@nicoburns nicoburns changed the title Fix: Reserve space for padding/borders/scrollbars in nodes with measure functions Reserve space for padding/borders/scrollbars in nodes with measure functions Jun 15, 2023
@nicoburns nicoburns force-pushed the fix/padding-border-scrollbar-with-measure branch from 6c0f49a to e5c6fa2 Compare June 15, 2023 19:22
@nicoburns nicoburns removed the blocked Cannot be advanced until something else changes label Jun 15, 2023
@alice-i-cecile alice-i-cecile merged commit 568f643 into DioxusLabs:main Jun 15, 2023
@alice-i-cecile
Copy link
Collaborator

Nice and simple! Great tests, like always.

@nicoburns nicoburns deleted the fix/padding-border-scrollbar-with-measure branch June 15, 2023 21:33
@nicoburns nicoburns added this to the 0.3.13 milestone Jul 17, 2023
nicoburns added a commit that referenced this pull request Aug 13, 2023
nicoburns added a commit that referenced this pull request Aug 13, 2023
nicoburns added a commit that referenced this pull request Aug 13, 2023
nicoburns added a commit that referenced this pull request Aug 14, 2023
nicoburns added a commit that referenced this pull request Aug 14, 2023
nicoburns added a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants