这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix flexbox baseline alignment #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 16, 2023
Merged

Fix flexbox baseline alignment #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
62270ae
Fix baseline alignment with margins and padding
nicoburns Jan 12, 2023
2b14163
Don't run baseline alignment on flex columns
nicoburns Jan 12, 2023
c9e4346
Enable baseline child multiline tests
nicoburns Jan 12, 2023
ca302c2
Refactor baseline alignment to be returned by perform_layout function
nicoburns Jan 12, 2023
2cc99ee
Only calculate child baseline for baseline alignment when necessary
nicoburns Jan 12, 2023
31ece5c
Add disabled test for grid item baseline alignment
nicoburns Jan 14, 2023
6b733e1
Apply suggestions from code review
nicoburns Jan 16, 2023
90e28e6
Add documentation on what a baseline is
nicoburns Jan 16, 2023
12ebb5f
Rename compute_generic functions back to compute
nicoburns Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions benches/generated/align_baseline_child_margin.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 62 additions & 0 deletions benches/generated/align_baseline_child_margin_percent.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

78 changes: 78 additions & 0 deletions benches/generated/align_baseline_child_multiline_no_override_on_secondline.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

79 changes: 79 additions & 0 deletions benches/generated/align_baseline_child_multiline_override.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 62 additions & 0 deletions benches/generated/align_baseline_child_padding.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading