这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Panquesito7
Copy link
Contributor

Summary

  • Update GitHub stars link.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I don't think this applies here.

  • Ran tests with composer test
  • Added or updated test cases to test new features

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I originally did it like this since it's easier to star the repo from the main page than from the stargazers page, but I am fine with this change

@DenverCoder1 DenverCoder1 changed the title chore: update GitHub stars link fix(demo): update GitHub stars link Jul 20, 2023
@DenverCoder1 DenverCoder1 merged commit 0033dc2 into DenverCoder1:main Jul 20, 2023
@DenverCoder1
Copy link
Owner

On second look, it appears that the github-buttons code requires the link to be in that format for the number of stars to show up, so I think this should be reverted for now.

image

image

DenverCoder1 added a commit that referenced this pull request Jul 20, 2023
@Panquesito7 Panquesito7 deleted the update_stars_link branch July 21, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants