这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@HectorSaldes
Copy link
Contributor

Summary

@DenverCoder1
Copy link
Owner

Looks great! 👍

Just as a side note for contributing to projects, it's usually a good idea to create the pull request from a side branch rather than from the fork's main branch.

Rather than upstream:main <- HectorSaldes:main, you could make it upstream:main <- HectorSaldes:added-hectorsaldes-to-readme. Doing so allows you work on multiple features on separate branches and more easily create a new feature branch if your fork's main branch is always up to date with the upstream project's main branch. It's not a huge issue, just mentioning it in case its helpful for the future.

@DenverCoder1 DenverCoder1 changed the title Added HectorSaldes to README docs(readme): Added HectorSaldes to examples Dec 21, 2022
@DenverCoder1 DenverCoder1 merged commit 7e74073 into DenverCoder1:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants