这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Vyvy-vi
Copy link
Contributor

@Vyvy-vi Vyvy-vi commented Oct 15, 2022

Summary

This PR adds a prettier github actions workflow to lint/format the code.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

closes #147

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Running composer format should resolve the checks (I could also probably merge it as is and hope the workflow does what it's supposed to).

Copy link
Contributor Author

@Vyvy-vi Vyvy-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wupps, there's a typo

Vyvy-vi and others added 2 commits October 16, 2022 12:05
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks 👍

I think it's good to merge since hopefully the workflow will fix the formatting automatically. 🤞

@DenverCoder1 DenverCoder1 merged commit 9581c33 into DenverCoder1:main Oct 16, 2022
@DenverCoder1
Copy link
Owner

Everything looks good 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate linting with prettier workflow

2 participants