这是indexloc提供的服务，不要输入任何密码
Skip to content

Added icon to web interface #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2022
Merged

Added icon to web interface #79

merged 4 commits into from
Jan 14, 2022

Conversation

@MagicLike
Copy link
Contributor

@MagicLike MagicLike commented Jan 13, 2022 •
edited
Loading

Description

I added an Twemoji as an icon for the web interface & updated the README with the licence attribution.

Fixes #57

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

  • Tested on own Heroku instance

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

new icon

@MagicLike
Copy link
Contributor Author

MagicLike commented Jan 13, 2022

I know it's pretty simple, but I think that it could be used until a proper logo or something else is made.

DenverCoder1
DenverCoder1 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Possibly we could change the name of the file from2328.png to something like favicon.png?

DenverCoder1
DenverCoder1 reviewed Jan 13, 2022
View reviewed changes
MagicLike and others added 2 commits January 14, 2022 14:38
@MagicLike @DenverCoder1
Update src/demo/index.php
390bd41 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@MagicLike
renamed icon
0606819
@MagicLike
Copy link
Contributor Author

MagicLike commented Jan 14, 2022

Done. 👍

DenverCoder1
DenverCoder1 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 82b22fe into DenverCoder1:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a favicon

2 participants

@MagicLike @DenverCoder1