这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(validator): make isRgbColor() accept boolean in 2nd arg #74084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −7
Open

feat(validator): make isRgbColor() accept boolean in 2nd arg #74084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/validator/es/lib/isRgbColor.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
import validator from "../../";
export type IsRgbColorOptions = validator.IsRgbColorOptions;
export default validator.isRgbColor;
2 changes: 1 addition & 1 deletion types/validator/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ declare namespace validator {
*
* @param [options] - Options
*/
export function isRgbColor(str: string, options?: IsRgbColorOptions): boolean;
export function isRgbColor(str: string, includePercentValuesOrOptions?: boolean | IsRgbColorOptions): boolean;

export type IdentityCardLocale =
| "ar-LY"
Expand Down
1 change: 1 addition & 0 deletions types/validator/lib/isRgbColor.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
import validator from "../";
export type IsRgbColorOptions = validator.IsRgbColorOptions;
export default validator.isRgbColor;
14 changes: 8 additions & 6 deletions types/validator/validator-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ import isOctalFunc from "validator/lib/isOctal";
import isPassportNumberFunc from "validator/lib/isPassportNumber";
import isPortFunc from "validator/lib/isPort";
import isPostalCodeFunc, { locales as isPostalCodeLocales } from "validator/lib/isPostalCode";
import isRgbColorFunc from "validator/lib/isRgbColor";
import isRgbColorFunc, { IsRgbColorOptions } from "validator/lib/isRgbColor";
import isSemVerFunc from "validator/lib/isSemVer";
import isSlugFunc from "validator/lib/isSlug";
import isStrongPasswordFunc from "validator/lib/isStrongPassword";
Expand Down Expand Up @@ -488,7 +488,7 @@ import isOctalFuncEs from "validator/es/lib/isOctal";
import isPassportNumberFuncEs from "validator/es/lib/isPassportNumber";
import isPortFuncEs from "validator/es/lib/isPort";
import isPostalCodeFuncEs, { locales as isPostalCodeLocalesEs } from "validator/es/lib/isPostalCode";
import isRgbColorFuncEs from "validator/es/lib/isRgbColor";
import isRgbColorFuncEs, { IsRgbColorOptions as IsRgbColorOptionsEs } from "validator/es/lib/isRgbColor";
import isSemVerFuncEs from "validator/es/lib/isSemVer";
import isSlugFuncEs from "validator/es/lib/isSlug";
import isStrongPasswordFuncEs from "validator/es/lib/isStrongPassword";
Expand Down Expand Up @@ -900,10 +900,12 @@ const any: any = null;
result = validator.isHSL("sample");

result = validator.isRgbColor("sample");
result = validator.isRgbColor("sample", { includePercentValues: true });
result = validator.isRgbColor("sample", { includePercentValues: false });
result = validator.isRgbColor("sample", { includePercentValues: true, allowSpaces: true });
result = validator.isRgbColor("sample", { allowSpaces: false });
result = validator.isRgbColor("sample", true);
result = validator.isRgbColor("sample", {});
result = validator.isRgbColor(
"sample",
{ includePercentValues: true, allowSpaces: true } satisfies IsRgbColorOptions,
);

result = validator.isHexadecimal("sample");

Expand Down