[new-relic-browser] modernize types from a namespace declaration to a module #74060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@twoowuv Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74060,
"author": "twoowuv",
"headCommitOid": "14f0a36e7b9f9f1e7463ecf4c099da9c8b638de6",
"mergeBaseOid": "e680e51b85628e26349de6e87302bcaa269cf984",
"lastPushDate": "2025-11-11T03:47:07.000Z",
"lastActivityDate": "2025-11-11T20:29:17.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "new-relic-browser",
"kind": "edit",
"files": [
{
"path": "types/new-relic-browser/index.d.ts",
"kind": "definition"
},
{
"path": "types/new-relic-browser/new-relic-browser-tests.ts",
"kind": "test"
}
],
"owners": [
"renehamburger",
"piotrkubisa"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 3514876384,
"ciResult": "pass"
} |
Contributor
|
🔔 @renehamburger @piotrkubisa — please review this PR in the next few days. Be sure to explicitly select |
a36f6b7 to
14f0a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR converts the existing namespace to a module. This is best practice (from the typescript docs: "we recommended modules over namespaces in modern code") and will allow users to more easily import and use the types as they would like.
I have only converted from a namespace to a module to keep this pr focused.
I've added the following to keep the behavior the same as the namespace currently provides:
pnpm test <package to test>.If changing an existing definition:
package.json.